Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for special testing "xx" language #702

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Support for special testing "xx" language #702

merged 1 commit into from
Aug 11, 2023
+51 −4

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Aug 11, 2023 •
edited
Loading

Problem

  • It is difficult to find out which texts are marked for translation
  • Or to find out untranslated string

Solution

  • "Translate" all texts in the _() and n_() functions, just convert them to X sequences
    • Just be careful of special %s or %d sequences, those should be kept

Notes

  • This of course handles only the texts generated by the web UI itself, it cannot mark the texts coming from the backed

Screenshots

  • Use ?lang=xx URL parameter, this can be entered only manually, we should never allow this in the UI

xx_lang

imobachgs
imobachgs approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea. LGTM. 😃

@coveralls
Copy link

Coverage Status

coverage: 72.05% (-0.09%) from 72.14% when pulling ad6ca30 on xx_lang into fff5ddf on master.

@lslezak lslezak merged commit a242827 into master Aug 11, 2023
10 checks passed
@lslezak lslezak deleted the xx_lang branch August 11, 2023 15:27
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lslezak @coveralls @imobachgs